From: Vincent Mailhol <vincent.mailhol@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Harald Mommer <hmo@opensynergy.com>,
Harald Mommer <harald.mommer@opensynergy.com>,
virtio-dev@lists.oasis-open.org, linux-can@vger.kernel.org,
Netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Dariusz Stojaczyk <Dariusz.Stojaczyk@opensynergy.com>,
Stratos Mailing List <stratos-dev@op-lists.linaro.org>
Subject: Re: [virtio-dev] [RFC PATCH 1/1] can: virtio: Initial virtio CAN driver.
Date: Sat, 5 Nov 2022 18:21:55 +0900 [thread overview]
Message-ID: <CAMZ6Rq+RjOHaGx-7GLsj-PNAcHd=nGd=JERddqw4FWbNN3sAXA@mail.gmail.com> (raw)
In-Reply-To: <ed2d2ea7-4a8c-4616-bca4-c78e6f260ba9@app.fastmail.com>
On Fry. 4 nov. 2022 at 20:13, Arnd Bergmann <arnd@kernel.org> wrote:
> On Thu, Nov 3, 2022, at 13:26, Harald Mommer wrote:
> > On 25.08.22 20:21, Arnd Bergmann wrote:
> >>
> ...
> > The messages are not necessarily processed in sequence by the CAN stack.
> > CAN is priority based. The lower the CAN ID the higher the priority. So
> > a message with CAN ID 0x100 can surpass a message with ID 0x123 if the
> > hardware is not just simple basic CAN controller using a single TX
> > mailbox with a FIFO queue on top of it.
Really? I acknowledge that it is priority based *on the bus*, i.e. if
two devices A and B on the same bus try to send CAN ID 0x100 and 0x123
at the same time, then device A will win the CAN arbitration.
However, I am not aware of any devices which reorder their own stack
according to the CAN IDs. If I first send CAN ID 0x123 and then ID
0x100 on the device stack, 0x123 would still go out first, right?
> > Thinking about this the code becomes more complex with the array. What I
> > get from the device when the message has been processed is a pointer to
> > the processed message by virtqueue_get_buf(). I can then simply do a
> > list_del(), free the message and done.
>
> Ok
next prev parent reply other threads:[~2022-11-05 9:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 13:44 [RFC PATCH 1/1] can: virtio: Initial virtio CAN driver Harald Mommer
2022-08-25 18:21 ` [virtio-dev] " Arnd Bergmann
2022-11-03 12:26 ` Harald Mommer
2022-11-04 10:50 ` Arnd Bergmann
2022-11-05 9:21 ` Vincent Mailhol [this message]
2023-05-12 13:19 ` Harald Mommer
2023-05-15 5:58 ` Vincent Mailhol
2023-05-23 13:39 ` Harald Mommer
2022-08-27 9:02 ` Oliver Hartkopp
2022-11-03 13:02 ` Harald Mommer
2022-08-27 9:39 ` Marc Kleine-Budde
2022-08-27 11:12 ` Oliver Hartkopp
2022-11-03 13:55 ` Harald Mommer
2022-11-04 15:32 ` [virtio-dev] " Jan Kiszka
2022-11-04 17:03 ` Arnd Bergmann
2023-02-03 15:02 ` Harald Mommer
2023-04-14 19:20 ` Marc Kleine-Budde
2023-04-18 9:50 ` Harald Mommer
2023-04-18 12:06 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZ6Rq+RjOHaGx-7GLsj-PNAcHd=nGd=JERddqw4FWbNN3sAXA@mail.gmail.com' \
--to=vincent.mailhol@gmail.com \
--cc=Dariusz.Stojaczyk@opensynergy.com \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=harald.mommer@opensynergy.com \
--cc=hmo@opensynergy.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stratos-dev@op-lists.linaro.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).